[PATCH] D23243: [clang-tidy] enhance modernize-use-bool-literals to check ternary operator

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 7 17:05:05 PDT 2016


2016-08-07 15:38 GMT-07:00 Aaron Ballman <aaron.ballman at gmail.com>:

On Sun, Aug 7, 2016 at 6:33 PM, Piotr Padlewski
> <piotr.padlewski at gmail.com> wrote:
> > Prazek added a comment.
> >
> > Yea, I also have never heard of it. I don't think it is worth even
> discussing
>
Just because you've never heard of a compiler extension that gets
> pointed out during review does not mean it's not worth discussing. Not
> everyone has heard of every compiler vendor extension we support,
> that's why we do public review in a wide audience. :-) Again, I am not
> suggesting the OP do this as part of this patch.
>
> GCC has many extensions. My point is that I also don't know any user that
use it.
Of course it doesn't imply that no one is using it, but I strongly belive
that
There are so few user in the word that I think it is much better to spend
time doing something other useful in clang-tidy than to even discuss this
topic.
It is good that you have mentioned it, at least I learned something new :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160807/5d08b3c3/attachment.html>


More information about the cfe-commits mailing list