[PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 5 10:51:17 PDT 2016

majnemer added a comment.

In https://reviews.llvm.org/D23086#507098, @Anastasia wrote:

> In https://reviews.llvm.org/D23086#507055, @majnemer wrote:
> > This approach seems wrong to me.
> >
> > Instead, why not just make `ndrange_t` a typedef of a real struct in `Sema::Initialize`?
> I think we have an issue because in that case during the diagnostic of enqueue_kernel Builtin in SemaChecking.cpp we won't have a good way to identify this type apart from checking its name...

That's OK, there are special types like this elsewhere (std::type_info from c++).

That's why ideally we would like to leave it as a special Builtin type.

> What kind of issues do you see with the current implementation?


> Also do you suggest to create the struct in Sema::Initialize? Alternatively, we also have an OpenCL header file for such things.



More information about the cfe-commits mailing list