[PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 5 10:19:17 PDT 2016

majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision now requires changes to proceed.

This approach seems wrong to me.

Instead, why not just make `ndrange_t` a typedef of a real struct in `Sema::Initialize`?

Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:32-36
@@ +31,7 @@
+  llvm::SmallVector<llvm::Type*,4> EleTypes;
+  llvm::Type* ArrEleType =
+      llvm::ArrayType::get(llvm::IntegerType::
+                         get(CGM.getLLVMContext(),
+                             CGM.PointerWidthInBits), 3);
This formatting looks wrong.



More information about the cfe-commits mailing list