[PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 4 12:09:22 PDT 2016

NoQ requested changes to this revision.
NoQ added a comment.
This revision now requires changes to proceed.

Whoops, because of a merge conflict while applying the patch, i noticed a few problems in the tests, they seem obvious, but could you have a quick look?

Comment at: test/Analysis/copypaste/functions.cpp:21
@@ -20,3 +20,3 @@
-// Functions below are not clones and should not be reported.
+// Different variable patterns, therefore different clones.
Not sure, do "different clones" mean "different code, should not be reported" or "different clones of the same code, should be reported"?

Comment at: test/Analysis/copypaste/functions.cpp:30
@@ +29,3 @@
+int minClone(int x, int y) { // expected-note{{Related code clone is here.}}
+  log();
This code is exactly identical, did you mean 'x > y' in any of those places?


More information about the cfe-commits mailing list