[PATCH] D23167: emit_DW_AT_noreturn flag

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 4 10:18:51 PDT 2016

aprantl added a comment.

Thanks for working in this!
Technically this is a DWARF 5 feature, but unknown attributes can be ignored by consumers, so there's no reason to emit it conditionally.

Could you please also add a test for llvm-dwarfdump?
Could you please also add a textual LLVM IR parser testcase?

Comment at: include/llvm/IR/DebugInfoMetadata.h:1424
@@ +1423,3 @@
+  ///
+  /// Return true if this subprogram is C++11 noreturn or C11 _Noreturn
+  unsigned isNoReturn() const {
The \brief is redundant. We compile doxygen with autobrief now.
Also, there's a missing . at the end.


More information about the cfe-commits mailing list