[PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 4 06:22:39 PDT 2016

alexfh marked an inline comment as done.

Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+  InDecl = InDecl.trim('_');
+  return InComment.compare_lower(InDecl) == 0;
aaron.ballman wrote:
> I think this is going to do the wrong thing for non-ASCII identifiers containing characters for which lowercase comparisons make no sense. I'm okay with that behavior (I don't think it should be a common occurrence), but would like to see a test demonstrating a failure case with a FIXME.
compare_lower will only modify ascii characters, all other characters will be compared as is.

As a purely theoretical question: are there characters that have lower-case variants, but it doesn't make sense to compare the lower-case variants? Can you give an example?


More information about the cfe-commits mailing list