[PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

[Balogh, Ádám via cfe-commits]

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D22374#504855, @NoQ wrote:

> Hmm. I suggest:
>
> 1. Change this test's constructor so that it was no longer almost-trivial. Because it isn't significant for this test if the constructor is almost-trivial or not. The test would pass.


It is significant, because I want to test here the almost-trivial constructors.

> 

> 

> 2. Add a FIXME-test for this checker, in which a completely undefined structure is being copied. Perhaps somebody implements this feature some day.


So it would be a new function with the same structure, and commented out beginning with a FIXME?

> 3. Leave out the situation that the current test checks as a grey-area. I'm still not convinced that this situation (copying a partially-initialized almost-trivial structure) deserves a warning from this checker.


This is what I originally did here in the patch. Maybe a FIXME could be written there a well?


https://reviews.llvm.org/D22374