[PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 3 07:34:55 PDT 2016


ioeric added inline comments.

================
Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:169
@@ +168,3 @@
+  // starts after R is (I+1).
+  if (I != Replaces.end() && *I == R)
+    ++I;
----------------
I think we should ignore replacement text when checking equality between `*I` and `R` here.


Repository:
  rL LLVM

https://reviews.llvm.org/D23119





More information about the cfe-commits mailing list