[PATCH] D23058: [clang-rename] improve USRFindingAction

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
 // RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i --
 // RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
----------------
Yes, but it's better to modify unrelated tests in a separate patch.

================
Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:3
@@ +2,3 @@
+// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
----------------
Yep, should also work with the same check prefix, if the replacements are the same.


https://reviews.llvm.org/D23058