[PATCH] D23008: [clang-tidy] fix segfault in cppcore-guidelines-special-member-functions check

Jonathan B Coe via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 13:25:54 PDT 2016

jbcoe marked an inline comment as done.

Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,3 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-    llvm::ArrayRef<SpecialMemberFunctionKind> SMFS, llvm::StringRef AndOr) {
+static std::string
+join(ArrayRef<SpecialMemberFunctionsCheck::SpecialMemberFunctionKind> SMFS,
+     llvm::StringRef AndOr) {
iterator_range loses me size, empty and index access. There's a function that gets and ArrayRef from a SmallSetVector (I wonder why there's no implicit conversion defined) so I can change the signature to take ArrayRef.


More information about the cfe-commits mailing list