[PATCH] D23014: [analyzer] Model base to derived casts more precisely.

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 09:02:06 PDT 2016

dcoughlin added a comment.

Other than a naming/documentation suggestion, looks good to me. Thanks Gábor!

Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:424
@@ +423,3 @@
+        if (!val.isZeroConstant()) {
+          val = getStoreManager().evalDynamicCast(val, T, Failed);
+        }
It seems a bit weird to call a method named "evalDynamicCast" when handling a static cast. What do you think about renaming evalDynamicCast() to to attemptDowncast() and updating its documentation to reflect its now-dual use?


More information about the cfe-commits mailing list