[PATCH] D23054: [clang-cl] Fix 2 pch tests to use x86_64 as target

Diana Picus via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 06:06:45 PDT 2016

rovka added a comment.

In https://reviews.llvm.org/D23054#503246, @rengolin wrote:

> All tests should have the target explicit, so I'd advocate for all of them to be changed.

Coming right up...

> Also, we need to make sure --target=x86_64 is enough on Windows. I remember some -target=arm not being enough (arm-eabi was enough, for some reason).

It's enough, I've seen it used in other clang-cl tests.


More information about the cfe-commits mailing list