[PATCH] D20196: [clang-tidy] Inefficient string operation
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 2 03:48:03 PDT 2016
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Sorry for the delay. I almost missed that there was an update to the patch. Please mark addressed comments as "Done". This way it's easier for me to track changes and it's easier for you not to miss review comments.
One more thing that this check lacks is fix-it hints, however, this can be added later.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.h:26
@@ +25,3 @@
+ InefficientStringConcatenationCheck(StringRef Name, ClangTidyContext *Context);
+ void registerMatchers(ast_matchers::MatchFinder *Finder) override;
The formatting is still off (specifically, indentation of `public:` and `private:` and the lack of an empty line before `private:`).
More information about the cfe-commits