[PATCH] D23009: [clang-rename] handle overridden functions correctly

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 09:26:28 PDT 2016

alexfh requested changes to this revision.
This revision now requires changes to proceed.

Comment at: test/clang-rename/FunctionOverride.cpp:3
@@ +2,3 @@
+class A { virtual void foo(); };    // CHECK: class A { virtual void boo(); };
+class B : public A { void foo(); }; // CHECK: class B : public A { void boo(); };
I guess, this test will pass even if clang-rename doesn't do any changes, since the pattern in the CHECK line will match with itself. There are multiple ways to fix this. For instance, you can anchor the pattern to the start of line (`// CHECK: {{ˆ}}class A ...`) or add `| sed 's,//.*,//'` to the pipeline before `| FileCheck %s`.


More information about the cfe-commits mailing list