r277206 - Ensure Ident_GNU_final is properly initialized in the Parser Initialize function

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 29 13:01:12 PDT 2016


Author: majnemer
Date: Fri Jul 29 15:01:12 2016
New Revision: 277206

URL: http://llvm.org/viewvc/llvm-project?rev=277206&view=rev
Log:
Ensure Ident_GNU_final is properly initialized in the Parser Initialize function

The recent change implementing __final forgot to initialize a variable.
This was caught by the Memory Sanitizer.

Properly initialize the value to nullptr to ensure proper memory reads.

Patch by Erich Keane!

Differential Revision: https://reviews.llvm.org/D22970

Modified:
    cfe/trunk/lib/Parse/Parser.cpp

Modified: cfe/trunk/lib/Parse/Parser.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/Parser.cpp?rev=277206&r1=277205&r2=277206&view=diff
==============================================================================
--- cfe/trunk/lib/Parse/Parser.cpp (original)
+++ cfe/trunk/lib/Parse/Parser.cpp Fri Jul 29 15:01:12 2016
@@ -473,6 +473,7 @@ void Parser::Initialize() {
   Ident_final = nullptr;
   Ident_sealed = nullptr;
   Ident_override = nullptr;
+  Ident_GNU_final = nullptr;
 
   Ident_super = &PP.getIdentifierTable().get("super");
 




More information about the cfe-commits mailing list