[PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 27 22:33:21 PDT 2016


zaks.anna added inline comments.

================
Comment at: test/Analysis/diagnostics/Inputs/include/Something.h:1
@@ +1,2 @@
+void clang_analyzer_warnIfReached();
+
----------------
Please, choose better file names. Every test that adds something cannot add a header called something:) It won't scale.

================
Comment at: test/Analysis/diagnostics/plist-diagnostics-include-check.cpp:1
@@ +1,2 @@
+// RUN: %clang_cc1 -analyze -analyzer-checker=debug.ExprInspection -analyzer-output=plist-multi-file -o plist.xml %s
+
----------------
Please, check that output is produced. Search for other tests with -analyzer-poutput=plist-multi-file for examples.


https://reviews.llvm.org/D22090





More information about the cfe-commits mailing list