[PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

[Raphael Isemann via cfe-commits]

teemperor added a comment.

Is there a specific situation/bug we want to test against with these tests? I looks to me as if they would mainly test against non-determinism (i.e. same statements have different data due to non-determinism).


================
Comment at: lib/Analysis/CloneDetection.cpp:113
@@ +112,3 @@
+
+  void addData(std::string const &String) {
+    D.AddString(String);
----------------
v.g.vassilev wrote:
> Same here, `const std::string &String`. Is this caught by clang-format?
It hasn't complained so far or I'm missing a flag. But it's also accepting many non-LLVM like naming schemes, so I assume it's quite forgiving in this regard.


https://reviews.llvm.org/D22514