[PATCH] D22855: [ARM] Pass thumb as architecture to the underlying tools, when targeting windows

[Renato Golin via cfe-commits]

rengolin added inline comments.

================
Comment at: test/Driver/thumb-attributes.s:1
@@ +1,2 @@
+@ RUN: %clang -target armv7-windows-itanium -c -o - %s \
+@ RUN:   | llvm-readobj -s - | FileCheck %s
----------------
mstorsjo wrote:
> rengolin wrote:
> > But we don't usually do asm tests in Clang. I can add this test to LLVM's MC dir.
> Do tests there also use the clang frontend driver? If you change it to test with llvm-mc with a thumb triplet, you won't actually test anything of this.
> 
> (Also, as long as this test uses clang, should it perhaps need a "// REQUIRES: arm-registered-target" at the start? I had that included in the other clang test, which was based on other old tests, while this one was changed from llvm-mc to clang.)
> If you change it to test with llvm-mc with a thumb triplet, you won't actually test anything of this.

That's a good point, actually. A better test for this one thing would be to make sure that whatever C file would generate an IR with a triple that is actually "thumb".


https://reviews.llvm.org/D22855