[PATCH] D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

[Haojian Wu via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

It looks good to me now, a few comments.  Let's wait to see whether @bkramer has any further comments.


================
Comment at: docs/include-fixer.rst:81
@@ +80,3 @@
+To run `clang-include-fixer` on a potentially unsaved buffer in Emacs. 
+Ensure that Emacs finds ``clang-include-fixer.el`` by adding the diretory containing the file to the ``load-path``
+and requiring the `clang-include-fixer` in your ```.emacs``:
----------------
s/diretory/directory

================
Comment at: include-fixer/tool/clang-include-fixer.el:23
@@ +22,3 @@
+  "clang-include-fixer"
+  "Location of the `clang-include-fixer' executable.
+
----------------
I might be wrong, I think it is missing a `"` at the end?

================
Comment at: include-fixer/tool/clang-include-fixer.el:51
@@ +50,3 @@
+  "Calls clang-include-fixer with parameters INCLUDE-FIXER-PARAMETER-[ABC].
+If the call was successful the returned result is stored in a temp buffer
+and the function CALLEE is called on this temp buffer."
----------------
code indentation.


https://reviews.llvm.org/D22805