[PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 20:28:36 PDT 2016


ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG with some nits


================
Comment at: include/clang/AST/OpenMPClause.h:4419
@@ -4405,1 +4418,3 @@
+  }
+  /// \brief Build clause with number of variables \a NumVars.
   ///
----------------
No \brief

================
Comment at: include/clang/AST/OpenMPClause.h:4439
@@ -4415,3 +4438,3 @@
 
-  /// Build an empty clause.
+  /// \brief Build an empty clause.
   ///
----------------
No \brief

================
Comment at: include/clang/AST/OpenMPClause.h:4457
@@ -4425,3 +4456,3 @@
 public:
-  /// Creates clause with a list of variables \a VL.
+  /// \brief Creates clause with a list of variables \a Vars.
   ///
----------------
No \brief

================
Comment at: include/clang/AST/OpenMPClause.h:4472
@@ -4438,1 +4471,3 @@
+
+  /// \brief Creates an empty clause with the place for \a NumVars variables.
   ///
----------------
No \brief

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5025
@@ -5024,1 +5024,3 @@
 
+  /// \brief Map between device pointer declarations and their expression
+  /// components. The key value for declarations in 'this' is null.
----------------
No \brief


https://reviews.llvm.org/D22788





More information about the cfe-commits mailing list