[PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 14:47:26 PDT 2016


benlangmuir added a comment.

We need to add this option to the module hash (see getModuleHash - we already add a bunch of other HSOpts there).  Otherwise the pcm could still be rewritten by a compilation that doesn't use a PCH, and then it would be out of date because of the timestamp instead of the diagnostic options.


https://reviews.llvm.org/D22773





More information about the cfe-commits mailing list