[PATCH] D22584: constexpr array support C++1z (P0031)

[Jason Turner via cfe-commits]

lefticus added a comment.

I believe all or most of the "untested" comments are correctly tested in the updated test files via static_asserts with contexpr. I've commented on just the first one to make sure I understand correctly.


================
Comment at: include/array:156
@@ -155,3 +155,3 @@
     _LIBCPP_INLINE_VISIBILITY
-    iterator begin() _NOEXCEPT {return iterator(__elems_);}
+    _LIBCPP_CONSTEXPR_AFTER_CXX14 iterator begin() _NOEXCEPT {return iterator(__elems_);}
     _LIBCPP_INLINE_VISIBILITY
----------------
This should be tested in begin.pass.cpp:28 correct?


https://reviews.llvm.org/D22584