[PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 10:33:23 PDT 2016


yaxunl added inline comments.

================
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning at +6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}}
+#else
----------------
Anastasia wrote:
> Can you move this error message down instead of adding 6 lines offset.
> Also the extension seems to be set by default although it's hard to see without the full diff. So why do you get this warning at all?
This warning is only for opencl version < 200. The extension is supported by OpenCL 2.0 and above only.


Repository:
  rL LLVM

https://reviews.llvm.org/D22637





More information about the cfe-commits mailing list