[PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 09:58:45 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG


================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+  auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+      InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
 
----------------
This doesn't seem to be an issue, since expression `v.push_back(obj.member())` won't trigger this check: it expects that the argument of the `push_back` call is a `cxxConstructExpr` or a `cxxFunctionalCastExpr`.


https://reviews.llvm.org/D22208





More information about the cfe-commits mailing list