[PATCH] D19815: Support '#pragma once' in headers when using PCH

Steve O'Brien via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 25 07:04:55 PDT 2016


elsteveogrande added a comment.

Looks like I have the "accept" ability in this repo, wasn't sure since I just registered for this recently :)

I think since the tests look good, it's a nice and elegant 1-line change, per the reviewer's (@rsmith 's) comments, this should be ok to go.

This would help greatly on a project I'm working on, which has reams of auto-generated headers, so naturally I'm antsy to get this in trunk :)

@wristow, if this still lands cleanly against trunk (I see that this has been around a while) and test still pass, think this can be committed soon-ish?

Thanks!


https://reviews.llvm.org/D19815





More information about the cfe-commits mailing list