[PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 23 00:18:54 PDT 2016


alexfh added a comment.

In https://reviews.llvm.org/D22656#493036, @Eugene.Zelenko wrote:

> Don't include DiagnosticIDs.h.


This header is just an example. I don't want anyone (including myself) manually figure out which of the headers inserted by IWYU actually need to be inserted. I'm also against adding #includes for every single transitively included header, since many of the headers can be considered "exported" by other headers. So, please, stop sending IWYU cleanups before reaching the general agreement and properly annotating LLVM and Clang headers.


Repository:
  rL LLVM

https://reviews.llvm.org/D22656





More information about the cfe-commits mailing list