[PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 23 00:10:19 PDT 2016


alexfh added a comment.

In https://reviews.llvm.org/D22208#492385, @Prazek wrote:

> There is one bug left:
>
> In the ClangIncludeFixer.cpp:169 there is push back that looks like this
>
> Symbols.push_back(find_all_symbols::SymbolInfo(
>
>   Split.first.trim(),
>   find_all_symbols::SymbolInfo::SymbolKind::Unknown,
>   CommaSplits[I].trim(), 1, {}, /*NumOccurrences=*/E - I));
>   
>
> There is initializer list inside that should not allow this to be matched (because I check for initializer list as argument)
>
> Unfortunatelly clang AST doesn't mention any initializer list.


I guess, `CXXConstructExpr::isListInitialization()` is what you need to check here.


Repository:
  rL LLVM

https://reviews.llvm.org/D22208





More information about the cfe-commits mailing list