[PATCH] D22507: Clang-tidy - Enum misuse check

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 22 02:34:55 PDT 2016


hokein added a comment.

Seems that you only uploaded the diff part, I only see the updated part of your patch now, and can't see the whole patch now (The review page says  "Context not available"), could you upload the whole patch again?


================
Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:31
@@ +30,3 @@
+
+//1.
+Enum {A, B, C}
----------------
Could you add some descriptions about what 1 stands for here? strict or non-strict?  please leave a blank between "//" and comment words, the same below. Make sure the code here align with code style.

================
Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:62
@@ +61,3 @@
+
+  unsigned flag = 0;
+  flag |= E; //ok
----------------
extra indentations.


https://reviews.llvm.org/D22507





More information about the cfe-commits mailing list