[PATCH] D21814: clang-rename: split existing options into two new subcommands

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 23:06:59 PDT 2016


klimek added inline comments.

================
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+    for (unsigned I = 0; I < NewNameList.size(); ++I) {
+      HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]);
+    }
----------------
Question is whether if we go down that route we shouldn't do one search for all the names, instead of re-looping for each name.


https://reviews.llvm.org/D21814





More information about the cfe-commits mailing list