[clang-tools-extra] r276282 - [clang-tidy] Avoid duplicated DenseMap lookup.
Benjamin Kramer via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 21 07:13:45 PDT 2016
Author: d0k
Date: Thu Jul 21 09:13:45 2016
New Revision: 276282
URL: http://llvm.org/viewvc/llvm-project?rev=276282&view=rev
Log:
[clang-tidy] Avoid duplicated DenseMap lookup.
The std::string is still constructed on demand. No functionality change
intended.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp?rev=276282&r1=276281&r2=276282&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Thu Jul 21 09:13:45 2016
@@ -176,8 +176,7 @@ DiagnosticBuilder ClangTidyContext::diag
assert(Loc.isValid());
unsigned ID = DiagEngine->getDiagnosticIDs()->getCustomDiagID(
Level, (Description + " [" + CheckName + "]").str());
- if (CheckNamesByDiagnosticID.count(ID) == 0)
- CheckNamesByDiagnosticID.insert(std::make_pair(ID, CheckName.str()));
+ CheckNamesByDiagnosticID.try_emplace(ID, CheckName);
return DiagEngine->Report(Loc, ID);
}
More information about the cfe-commits
mailing list