[PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in <atomic>. Fixes PR21179.

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 07:13:43 PDT 2016


bcraig added inline comments.

================
Comment at: include/atomic:569
@@ +568,3 @@
+    __attribute__ ((__enable_if__(__m == memory_order_release                 \
+                               || __m == memory_order_acq_rel, "")))          \
+    __attribute__ ((__unavailable__("memory order argument to atomic operation is invalid")))
----------------
Gah, read the logic backwards... and even backwards my comments are incomplete.


https://reviews.llvm.org/D22557





More information about the cfe-commits mailing list