[PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 21 03:09:44 PDT 2016


hokein added inline comments.

================
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:365
@@ +364,3 @@
+  for (const auto &Info : Context.getQuerySymbolInfos()) {
+    Replacements->insert({FilePath, Info.Range.getOffset(),
+                          Info.Range.getLength(),
----------------
ioeric wrote:
> Now that we insert namespace qualifiers, we might want to do a `formatReplacements` before applying them.
Good point! So that we won't break the current code style. The line probably exceeds 80 characters after adding qualifiers.


https://reviews.llvm.org/D22567





More information about the cfe-commits mailing list