[PATCH] D22593: [Profile] document %h and %m

Xinliang David Li via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 20 16:38:31 PDT 2016


ok

David

On Wed, Jul 20, 2016 at 4:32 PM, Sean Silva <chisophugis at gmail.com> wrote:

> silvas accepted this revision.
> silvas added a comment.
> This revision is now accepted and ready to land.
>
> LGTM (also, another small suggestion).
>
>
> ================
> Comment at: docs/UsersManual.rst:1502
> @@ +1501,3 @@
> +   multiple raw profiles dumped from different processes (running on the
> same or
> +   different hosts) will be automatically merged by the profiler runtime
> during the
> +   dumping. If the program links in multiple instrumented shared
> libraries, each library
> ----------------
> "running on the same or different hosts" should probably just be "that
> share a file system" to clarify that we depend on the filesystem guarantees
> and aren't doing anything else special.
>
>
> https://reviews.llvm.org/D22593
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160720/daabd990/attachment.html>


More information about the cfe-commits mailing list