[PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

Ed Maste via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 11:17:13 PDT 2016


emaste added a subscriber: emaste.

================
Comment at: docs/Proposals/GitHub.rst:8-9
@@ +7,4 @@
+
+This is a proposal to move our current revision control system from Subversion
+to GitHub. Below are the financial and technical arguments as to why we need
+such a move and how will people (and validation infrastructure) continue to work
----------------
It seems pedantic, but I think we should try hard to avoid conflating Git and GitHub. What about: "move our revision control system from //self-hosted// Subversion to Git hosted by GitHub."

================
Comment at: docs/Proposals/GitHub.rst:93
@@ +92,3 @@
+Furthermore, GitHub has an *SVN view* (https://github.com/blog/626-announcing-svn-support)
+where people stuck with SVN infrastructure and tooling can slowly migrate or
+even stay working as if it was an SVN repository (including read-write access).
----------------
Replace "stuck" with something neutral. "stuck" implies that everyone will want to move but some may not be able to for technical or other reasons, but some people actually prefer SVN.

================
Comment at: docs/Proposals/GitHub.rst:180
@@ +179,3 @@
+
+As soon as we decide to move, we'll have to set a date for the process to begin.
+
----------------
This presents it as if the decision is already made, which somewhat defeats the purpose of writing a proposal for the LLVM community to vote on.

Maybe "If we decide to move"?


https://reviews.llvm.org/D22463





More information about the cfe-commits mailing list