[PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

Balogh, Ádám via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 03:38:27 PDT 2016


baloghadamsoftware added inline comments.

================
Comment at: test/Analysis/ctor.mm:177
@@ -176,3 +176,3 @@
       Inner(const Inner &Other)
-        : x(Other.x), y(Other.y) // expected-warning {{undefined}}
+        : x(Other.x), y(Other.y) // no-warning
       {
----------------
a.sidorin wrote:
> Seems like we may lose some warnings due to this change. Did you test this change on some real code?
Sorry, but no. We got rid of a false positive (debug checker?). The member of the new object are no longer undefined since we do a trivial copy here because this copy constructor is "almost trivial".


https://reviews.llvm.org/D22374





More information about the cfe-commits mailing list