[PATCH] D22408: [clang-rename] add support for overridden functions

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 02:03:17 PDT 2016


omtcyfz marked an inline comment as done.

================
Comment at: clang-rename/USRFindingAction.cpp:48
@@ +47,3 @@
+//
+// FIXME: It's better to match ctors/dtors via typeLoc's instead of adding
+// their USRs to the storage, because we can also match CXXConversionDecl's by
----------------
Thanks for the feedback!
a) done
b) using std::set instead and pushing into std::vector afterwards. I thing it's simple and efficient, too.


https://reviews.llvm.org/D22408





More information about the cfe-commits mailing list