[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

Jonas Hahnfeld via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 00:14:42 PDT 2016


Hahnfeld added a subscriber: Hahnfeld.

================
Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:113-119
@@ -80,1 +112,9 @@
+    }
+    if (ec) {
+        assert(new_write_time == old_write_time);
+        return false;
+    } else {
+        assert(new_write_time > old_write_time);
+        return true;
+    }
 }
----------------
Hmm no, this doesn't work for me: `fs::last_write_time` just takes the negative timestamp and overflows somewhere internally...


https://reviews.llvm.org/D22452





More information about the cfe-commits mailing list