[PATCH] D22237: clang-rename: fix renaming member functions

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 15 23:45:40 PDT 2016

omtcyf0 added a comment.


Sorry for a late response.

The issue is that you only deal with the consequences of this "bug". Overridden functions simply have different USRs, so the solution is just to add relevant USRs. Trying to deal with it in `USRLocFinder.cpp` doesn't seem right; the chances of dealing with such issue correctly on that side are very small. I.e. it still doesn't pass the more complicated test I have in my patch (see below).

There's a patch I've been working on lately, it does exactly that. https://reviews.llvm.org/D22408 (it's from the other account I'll have to use from now, nvm)


More information about the cfe-commits mailing list