[PATCH] D19544: Pass for translating math intrinsics to math library calls.

Hal Finkel via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 15 16:50:51 PDT 2016

hfinkel added a comment.

In https://reviews.llvm.org/D19544#485677, @mmasten wrote:

> Thanks for reviewing. One concern I have going forward is the number of entries that will appear in the switch statement inside addVectorizableFunctionsFromVecLib(). I assume that the right thing to do is to replace this with something that is TableGen'd?

I completely agree; this seems like a good candidate to be TableGen'd.

> Also, I just wanted to point out that some of these entries will result in svml calls that are not legal. E.g., __svml_sinf32 does not actually exist in the library, but can be legalized in case one explicitly sets a vector length of 32. Although these types of cases are probably not common, I wanted to bring this to your attention since the legalization piece of this work will be reviewed and committed separately. If needed, I can remove those entries until the legalization is in place.

Yes, let's start only with the directly-legal calls.


More information about the cfe-commits mailing list