[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

Jake VanAdrighem via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 15:46:39 PDT 2016

jakev added inline comments.

Comment at: test/Profile/gcc-flag-compatibility.c:10
@@ -9,3 +9,3 @@
-// Check that -fprofile-generate uses the runtime default profile file.
+// Check that -fprofile-generate overrides the default profraw.
 // RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate | FileCheck -check-prefix=PROFILE-GEN %s
davidxl wrote:
> Please add a FIXME here. I noticed that there is a bug in IR PGO implementation that -fprofile-generate still invokes overrider api in instrumentation which is unnecessary.
I actually have a patch that fixes this behavior. I can post it once this patch has landed.



More information about the cfe-commits mailing list