[PATCH] D22237: clang-rename: fix renaming member functions

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 01:48:53 PDT 2016


omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.

This one doesn't fix it though.

It only deals with declarations of overridden functions.

This is the test that still fails:

  / RUN: cat %s > %t.cpp
  // RUN: clang-rename -offset=161 -new-name=boo %t.cpp -i --
  // RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
  // XFAIL: *
  
  class A {
  public:
    virtual void foo() {}
  };
  
  class B : public A {
  public:
    void foo() override {}  // OK: B::foo overrides A::foo
  };
  
  int main() {
    A a;
    a.foo();
  
    B b;
    b.foo();
  
    return 0;
  }
  
  // Use grep -FUbo 'Cla' <file> to get the correct offset of foo when changing
  // this file.


http://reviews.llvm.org/D22237





More information about the cfe-commits mailing list