[PATCH] D22299: [include-fixer] Implement adding missing namespace qualifiers in vim integration.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 06:02:50 PDT 2016

hokein added inline comments.

Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+    assert(!HeaderInfos.empty());
+    // Only accept an unique header.
+    bool IsUniqueHeader = std::equal(
bkramer wrote:
> In that case adjacent_find was the right choice, but std::equal also works, I read this wrong. There are multiple ways of doing this using standard algorithms and none of them is really obvious. Please add a comment here that you're checking that all elements are equal.
Done. To me, `equal` is more obvious than `adjacent_find`.


More information about the cfe-commits mailing list