[PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pierre gousseau via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 05:05:59 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL275261: [PCH] Fix timestamp check on windows hosts. (authored by pgousseau).

Changed prior to commit:
  http://reviews.llvm.org/D20867?vs=59887&id=63794#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D20867

Files:
  cfe/trunk/lib/Serialization/ASTReader.cpp

Index: cfe/trunk/lib/Serialization/ASTReader.cpp
===================================================================
--- cfe/trunk/lib/Serialization/ASTReader.cpp
+++ cfe/trunk/lib/Serialization/ASTReader.cpp
@@ -2010,17 +2010,8 @@
   // For an overridden file, there is nothing to validate.
   if (!Overridden && //
       (StoredSize != File->getSize() ||
-#if defined(LLVM_ON_WIN32)
-       false
-#else
-       // In our regression testing, the Windows file system seems to
-       // have inconsistent modification times that sometimes
-       // erroneously trigger this error-handling path.
-       //
-       // FIXME: This probably also breaks HeaderFileInfo lookups on Windows.
        (StoredTime && StoredTime != File->getModificationTime() &&
         !DisableValidation)
-#endif
        )) {
     if (Complain) {
       // Build a list of the PCH imports that got us here (in reverse).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20867.63794.patch
Type: text/x-patch
Size: 900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160713/6574a8bf/attachment.bin>


More information about the cfe-commits mailing list