[PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 12 12:44:39 PDT 2016

majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision now requires changes to proceed.

This requires an associated test case.

Comment at: lib/Sema/SemaDecl.cpp:14354-14355
@@ -14353,2 +14353,4 @@
           if (!isRepresentableIntegerValue(Context, EnumVal, EltTy)) {
-            if (getLangOpts().MSVCCompat) {
+            if (getLangOpts().MSVCCompat ||
+                Context.getTargetInfo().getCXXABI().isMicrosoft()) {
+              // Treat as an extension in MSVC compat mode or if using the
I would remove the `getLangOpts().MSVCCompat`.


More information about the cfe-commits mailing list