[PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

Carlo Bertolli via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 12 09:20:32 PDT 2016


carlo.bertolli marked 3 inline comments as done.

================
Comment at: lib/Sema/SemaOpenMP.cpp:11648
@@ +11647,3 @@
+    // item should be a pointer or reference to pointer
+    if (!Type.getNonReferenceType()->isPointerType()) {
+      Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
----------------
ABataev wrote:
> What if Type is dependent?
In that case at line 8084 (function getPrivateItem) will return the pair (nullptr, true) and at line 11640 I will push nullptr for later analysis.
If this is not enough, can you please explain what needs to be done? Thanks!!


Repository:
  rL LLVM

http://reviews.llvm.org/D21904





More information about the cfe-commits mailing list