[PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

John McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 12 08:26:26 PDT 2016

rjmccall added inline comments.

Comment at: lib/CodeGen/CodeGenFunction.h:2725
@@ -2724,3 +2724,3 @@
   void EmitStoreOfScalar(llvm::Value *Value, Address Addr,
-                         bool Volatile, QualType Ty,
+                         bool Volatile, bool Restrict, QualType Ty,
                          AlignmentSource AlignSource = AlignmentSource::Type,
majnemer wrote:
> Multiple bool parameters aren't super great. Could we make it an enum and `|` the two properties as needed?  If it's super painful, this could be done later.
Alternatively, is there a reason that the qualifiers on Ty aren't sufficient for this?  If we're passing down the access type anyway, I'm not sure why we need to be separately passing Volatile.


More information about the cfe-commits mailing list