[PATCH] D21453: Add support for attribute "overallocated"

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 15:15:01 PDT 2016

ahatanak added inline comments.

Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2170
@@ +2169,3 @@
+  "'flexible_array' attribute only applies to %select{"
+  "the last member of a struct|members of structs or classes|"
+  "fixed sized array members|array members that have at least one element}0">;
aaron.ballman wrote:
> I think "members of structs or classes" and "the last member of a struct" could be combined into "the last member of a non-union class", instead of using separate diagnostic text. What do you think?
I agree, I think these two diagnostics should be combined.


More information about the cfe-commits mailing list