[PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'
Carlo Bertolli via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 11 09:49:28 PDT 2016
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
> No positive tests for the construct
Do you mean in the regression test? I thought I covered all negative and positive cases, but please let me know if I missed anything.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333
@@ -8332,1 +8332,3 @@
"expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'">;
+def err_omp_usedeviceptr_not_a_pointer : Error<
+ "expected pointer in 'use_device_ptr' clause">;
> Shall we accept refs to pointers and arrays?
I think that people of the OpenMP committee agreed that we can accept references to pointers. There is no indication in the specifications about arrays, so I will leave them out for the time being.
I will add a mention of references here.
More information about the cfe-commits