[PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 09:20:44 PDT 2016


Anastasia added inline comments.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:1681
@@ -1692,1 +1680,3 @@
 
+  // -cl-strict-aliasing needs to emit diagnostic in the case where CL > 1.0.
+  // This option should be deprecated for CL > 1.0 because
----------------
Was this code moved intensionally?

================
Comment at: test/Frontend/opencl-blocks.cl:9
@@ -8,1 +8,3 @@
 // RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify -fsyntax-only
+// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck --check-prefix=CHECK-INVALID-OPENCL-VERSION11 %s
+// RUN: %clang_cc1 -cl-std=CL1.2 -cl-strict-aliasing %s 2>&1 | FileCheck --check-prefix=CHECK-INVALID-OPENCL-VERSION12 %s
----------------
yaxunl wrote:
> Better separate these tests to another file, e.g. cl-strict-aliasing.cl
I think it was right to have this in test/Driver/opencl.cl. Why was it moved in here?


Repository:
  rL LLVM

http://reviews.llvm.org/D22170





More information about the cfe-commits mailing list