[PATCH] D14326: ASTImporter: expressions, pt.2

[Serge Pavlov via cfe-commits]

2016-07-01 15:26 GMT+06:00 Aleksei Sidorin <a.sidorin at samsung.com>:

> a.sidorin updated this revision to Diff 62474.
> a.sidorin added a comment.
>
> Fix some issues pointed by Serge Pavlov.
> Serge: putting a check of FriendDecls to `IsStructurallyEquivalent()`
> seems like a good idea for me, but we need some additional changes for it.
> `CXXRecodeDecl::getFirstDecl()` is private and
> `StructuralEquivalenceContext()` is located in an anonymous namespace so we
> cannot forward-declare it in DeclCXX.h to make it friend. We can move
> `StructuralEquivalenceContext()` out of anonymous namespace, however. What
> do you think?
>
>
I don't think this small improvement in Importer is worth invasive changes
in other components.

Thanks,
--Serge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160709/0f3468a6/attachment.html>